Merged
Conversation
... which appear to work fine in Chrome 64
Collaborator
|
Nice! So previously we had: Now we have: ie total 45 skipped, or 27 more tests than we used to run on CI 🎉 Most of those are mapbox, so there are just a few that we might want to continue to investigate later. No changes from me, this looks great! 💃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits our jasmine test suites (which is getting pretty heavy 🍔 ) into 2 separate CircleCI jobs: one for our gl3d, gl2d and parcoords tests (tag
@gl) and another for all the other tests that aren't skipped on CI (that@noCItag).This does two things:
Moreover, the PR removes a few
@noCItags from our suites. Upgrading to Chrome 64 in #2323 made some tests work on CI. To note, @monfera almost all yourparcoordstests are runned on CI now.cc @alexcjohnson @dfcreative @nicolaskruchten